feat(spans): Extract INP metrics from spans #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
Jan 19, 2024
jjbayer
reviewed
Jan 19, 2024
jjbayer
approved these changes
Jan 22, 2024
jjbayer
reviewed
Jan 25, 2024
|
SDKs are not sending this measurement yet, volume will be 0 until the next release. |
jjbayer
reviewed
Feb 1, 2024
Comment on lines
+361
to
+366
| let mut event = Event { | ||
| contexts, | ||
| measurements: span.measurements.clone(), | ||
| spans: Annotated::from(vec![Annotated::new(span.clone())]), | ||
| ..Default::default() | ||
| }; |
There was a problem hiding this comment.
This turned out hackier than I thought, with all the cloning. We could instead create the pseudo-event before the retain_items loop, pass that into normalize() instead, and .take() measurements & spans in and out of that to prevent cloning. But I would not invest time into that, we should instead have a generic normalize_performance_score function that works on both spans and events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2873.