Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(normalization): Move span validation to NormalizeProcessor #2679

Merged
merged 20 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
40eadd6
NormalizeProcessor -> StoreNormalizeProcessor
iker-barriocanal Oct 25, 2023
da55d0d
Move light normalization logic to new processor
iker-barriocanal Oct 30, 2023
d0647e8
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal Oct 30, 2023
b4aa66e
ref(normalization): Move span validation to NormalizeProcessor
iker-barriocanal Oct 31, 2023
01c5c7a
Move span validation to span module
iker-barriocanal Oct 31, 2023
87a0d37
update changelogs
iker-barriocanal Oct 31, 2023
5e83445
move span validation to its own module
iker-barriocanal Oct 31, 2023
59b868c
more explicit changelog for renormalization
iker-barriocanal Oct 31, 2023
4db2a5c
fix lint
iker-barriocanal Oct 31, 2023
ee98472
actually make it a docstring
iker-barriocanal Oct 31, 2023
7d269b4
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal Oct 31, 2023
9bb2bfe
Merge branch 'iker/feat/normalize-processor' into iker/ref/tx-proc-no…
iker-barriocanal Oct 31, 2023
de0ed1b
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal Nov 6, 2023
4a26e79
add some docs and fix typo
iker-barriocanal Nov 6, 2023
6af1034
add missing import
iker-barriocanal Nov 6, 2023
015b331
bring NEL normalization back
iker-barriocanal Nov 6, 2023
685d872
Merge branch 'iker/feat/normalize-processor' into iker/ref/tx-proc-no…
iker-barriocanal Nov 6, 2023
b2a6730
Merge branch 'master' into iker/ref/tx-proc-norm-proc
iker-barriocanal Nov 7, 2023
7d57e2b
Merge branch 'master' into iker/ref/tx-proc-norm-proc
iker-barriocanal Nov 9, 2023
1816f88
address feedback
iker-barriocanal Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Disable resource link span ingestion. ([#2647](https://github.com/getsentry/relay/pull/2647))
- Collect `http.decoded_response_content_length`. ([#2638](https://github.com/getsentry/relay/pull/2638))
- Add TTID and TTFD tags to mobile spans. ([#2662](https://github.com/getsentry/relay/pull/2662))
- Validate span timestamps and IDs in light normalization. ([#2679](https://github.com/getsentry/relay/pull/2679))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need a changelog for this? Span validation was already part of light normalization (through the TransactionProcessor), so that does not change from an outsider's point of view. Let me know if I'm missing something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! These checks didn't run when renormalize was enabled, which now do (first note on the PR description). I updated the changelog to be a bit more explicit.


## 23.10.1

Expand Down
4 changes: 4 additions & 0 deletions py/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Validate span timestamps and IDs in light normalization. ([#2679](https://github.com/getsentry/relay/pull/2679))

## 0.8.33

- Drop events starting or ending before January 1, 1970 UTC. ([#2613](https://github.com/getsentry/relay/pull/2613))
Expand Down
4 changes: 2 additions & 2 deletions relay-event-normalization/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,15 @@ pub struct StoreConfig {
/// See the fields of [`StoreConfig`] for a description of all normalization steps.
pub struct StoreProcessor<'a> {
config: Arc<StoreConfig>,
normalize: normalize::NormalizeProcessor<'a>,
normalize: normalize::StoreNormalizeProcessor<'a>,
}

impl<'a> StoreProcessor<'a> {
/// Creates a new normalization processor.
pub fn new(config: StoreConfig, geoip_lookup: Option<&'a GeoIpLookup>) -> Self {
let config = Arc::new(config);
StoreProcessor {
normalize: normalize::NormalizeProcessor::new(config.clone(), geoip_lookup),
normalize: normalize::StoreNormalizeProcessor::new(config.clone(), geoip_lookup),
config,
}
}
Expand Down
Loading
Loading