-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(normalization): Move span validation to NormalizeProcessor #2679
Merged
Merged
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
40eadd6
NormalizeProcessor -> StoreNormalizeProcessor
iker-barriocanal da55d0d
Move light normalization logic to new processor
iker-barriocanal d0647e8
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal b4aa66e
ref(normalization): Move span validation to NormalizeProcessor
iker-barriocanal 01c5c7a
Move span validation to span module
iker-barriocanal 87a0d37
update changelogs
iker-barriocanal 5e83445
move span validation to its own module
iker-barriocanal 59b868c
more explicit changelog for renormalization
iker-barriocanal 4db2a5c
fix lint
iker-barriocanal ee98472
actually make it a docstring
iker-barriocanal 7d269b4
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal 9bb2bfe
Merge branch 'iker/feat/normalize-processor' into iker/ref/tx-proc-no…
iker-barriocanal de0ed1b
Merge branch 'master' into iker/feat/normalize-processor
iker-barriocanal 4a26e79
add some docs and fix typo
iker-barriocanal 6af1034
add missing import
iker-barriocanal 015b331
bring NEL normalization back
iker-barriocanal 685d872
Merge branch 'iker/feat/normalize-processor' into iker/ref/tx-proc-no…
iker-barriocanal b2a6730
Merge branch 'master' into iker/ref/tx-proc-norm-proc
iker-barriocanal 7d57e2b
Merge branch 'master' into iker/ref/tx-proc-norm-proc
iker-barriocanal 1816f88
address feedback
iker-barriocanal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need a changelog for this? Span validation was already part of light normalization (through the
TransactionProcessor
), so that does not change from an outsider's point of view. Let me know if I'm missing something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! These checks didn't run when
renormalize
was enabled, which now do (first note on the PR description). I updated the changelog to be a bit more explicit.