feat(metrics): Implement generic metric extraction for transactions #2257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Jun 28, 2023
jan-auer
added a commit
that referenced
this pull request
Jun 28, 2023
* master: feat(metrics): Implement generic metric extraction for transactions (#2257)
Comment on lines
+2148
to
+2150
| // XXX: Since we only support transactions, we can skip generic metric extraction from | ||
| // events if transaction metrics have been extracted before. | ||
| if !state.transaction_metrics_extracted { |
There was a problem hiding this comment.
I guess this doesn't consider external relays for now, but I think that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial version of generic metrics extraction based on the
previously added schema (#2252). It is limited to transaction events and
evaluates conditions with the fields supported by
FieldValueProvider.Since generic metric extraction can operate on all item types, the a new
top-level processing function is added that runs before the more
specific transaction metric extraction. In the future, we will convert
conditional tagging logic and even transaction metric extraction
configuration to the new format when the project config is read, so that
the old functions can be removed.
Since the new function supports only transactions, it reuses the
existing
transaction_metrics_extractedflag from the processing state.This is subject to change in a follow-up.
Closes #2257