Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(general): Reject exceptions with empty type and value #170

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jan 25, 2019

Fixes SENTRY-96G

@jan-auer jan-auer self-assigned this Jan 25, 2019
@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #170 into master will increase coverage by 0.05%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #170      +/-   ##
=========================================
+ Coverage   63.85%   63.9%   +0.05%     
=========================================
  Files          82      82              
  Lines        8792    8814      +22     
=========================================
+ Hits         5614    5633      +19     
- Misses       3178    3181       +3
Impacted Files Coverage Δ
general/src/protocol/exception.rs 97.82% <100%> (+2.7%) ⬆️
general/src/store/normalize/contexts.rs 92.14% <100%> (ø) ⬆️
general/src/store/normalize.rs 92.59% <100%> (+0.12%) ⬆️
general/src/store/normalize/stacktrace.rs 100% <100%> (ø) ⬆️
general/src/types/impls.rs 80.86% <50%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ebf37...1284589. Read the comment docs.

@untitaker untitaker merged commit de824ed into master Jan 25, 2019
@untitaker untitaker deleted the fix/exception-empty-fields branch January 25, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants