Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): Rename misnamed aggregator option #1298

Merged
merged 3 commits into from
Jun 9, 2022
Merged

fix(metrics): Rename misnamed aggregator option #1298

merged 3 commits into from
Jun 9, 2022

Conversation

untitaker
Copy link
Member

#skip-changelog

@untitaker untitaker requested a review from a team June 8, 2022 14:19
jjbayer
jjbayer approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment on docs, plus some usages must be replaced by the new name, but other than that LGTM.

relay-metrics/src/aggregation.rs Outdated Show resolved Hide resolved
@jan-auer
Copy link
Member

jan-auer commented Jun 9, 2022

Note that test code still needs updating so this compiles.

@untitaker
Copy link
Member Author

i forgot to push that. now it should work

@untitaker untitaker merged commit 7511841 into master Jun 9, 2022
@untitaker untitaker deleted the fix/rename-aggr-option branch June 9, 2022 12:46
jan-auer added a commit that referenced this pull request Jun 9, 2022
@jan-auer
Merge branch 'master' into jferg/replay-recordings
a54ef48 
* master:
  ref(metrics): Stop logging relative bucket size (#1302)
  fix(metrics): Rename misnamed aggregator option (#1298)
  fix(server): Avoid a panic in the Sentry middleware (#1301)
  build: Update dependencies with known vulnerabilities (#1294)
  fix(metrics): Stop logging statsd metric per project key (#1295)
  feat(metrics): Limits on bucketing cost in aggregator [INGEST-1132] (#1287)
  fix(metrics): Track memory footprint more accurately (#1288)
  build(deps): Bump dependencies (#1293)
  feat(aws): Add relay-aws-extension crate which implements AWS extension as an actor (#1277)
  fix(meta): Update codeowners for the release actions (#1286)
  feat(metrics): Track memory footprint of metrics buckets (#1284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@flub flub flub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@untitaker @jan-auer @flub @jjbayer