-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-valued metric tags not supported #3691
Comments
Neither Relay nor storage support multi-value tags. Fixes getsentry/relay#3691.
Hey @jjbayer, I don't have a specific use case for it, just opened this issue to make sure things are aligned. I'll remove Tuple and List from the Python SDK's type hints for tag values. |
@jjbayer To be clear, I believe that @elramen is referring to the tag values (i.e. the values of the tags dictionary), which in the Python docs examples are all strings. The question is referring to whether the tags could have multiple values, e.g. by setting a value in the dictionary to a list. The tags would still be defined in a dictionary |
A single metric emission can only have one value per key and every key must be unique. Please check the docs PR if that new explanation does make sense to you. |
Remove Tuple and List from the MetricTagValue type as these are not supported and might confuse the user. See getsentry/relay#3691 for more information.
Remove Tuple and List from the MetricTagValue type as these are not supported and might confuse the user. See getsentry/relay#3691 for more information.
The metrics developer docs say "metrics are tagged by key value pairs, where each key can have more than one value." Also the RFC says "More than one value per key is permitted if represented as a list or tuple." Multi-valued tags is also implemented in the python sdk (not sure about the other sdks).
However, it seems that relay doesn't allow multi-valued tags for single emissions, only the last value of the list/tuple sent is actually used. Have raised this issue offline but opening it here so it's not forgotten.
The text was updated successfully, but these errors were encountered: