Skip to content

Commit

Permalink
fix(metrics): Stop logging statsd metric per project key (#1295)
Browse files Browse the repository at this point in the history
It seems that we hit a limit by submitting too many statsd metrics, so
let's stop emitting BucketCostPerProjectKey.
  • Loading branch information
jjbayer authored Jun 8, 2022
1 parent b59b6d5 commit d8f887a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
5 changes: 0 additions & 5 deletions relay-metrics/src/aggregation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1518,11 +1518,6 @@ impl Aggregator {
relay_statsd::metric!(
gauge(MetricGauges::BucketsCost) = self.cost_tracker.total_cost as u64
);
for cost in self.cost_tracker.cost_per_project_key.values() {
relay_statsd::metric!(
histogram(MetricHistograms::BucketsCostPerProjectKey) = *cost as f64
);
}

let mut buckets = HashMap::<ProjectKey, Vec<Bucket>>::new();

Expand Down
6 changes: 0 additions & 6 deletions relay-metrics/src/statsd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,6 @@ pub enum MetricHistograms {
/// - `backdated`: A flag indicating whether the metric was reported within the `initial_delay`
/// time period (`false`) or after the initial delay has expired (`true`).
BucketsDelay,

/// The storage cost of metrics buckets stored Relay's metrics aggregator, for a project key.
///
/// See also [`MetricGauges::BucketsCost`].
BucketsCostPerProjectKey,
}

impl HistogramMetric for MetricHistograms {
Expand All @@ -117,7 +112,6 @@ impl HistogramMetric for MetricHistograms {
Self::BucketsFlushedPerProject => "metrics.buckets.flushed_per_project",
Self::BucketRelativeSize => "metrics.buckets.relative_bucket_size",
Self::BucketsDelay => "metrics.buckets.delay",
Self::BucketsCostPerProjectKey => "metrics.buckets.cost_per_project_key",
}
}
}
Expand Down

0 comments on commit d8f887a

Please sign in to comment.