This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat(binaries): precompile binaries #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/feat/precompile
branch
16 times, most recently
from
c08ec1f to
07940dd
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
5 times, most recently
from
fb51fae to
c65afab
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
from
c65afab to
a839921
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
2 times, most recently
from
0f685ad to
537d743
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
2 times, most recently
from
38f7eae to
014fc67
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
3 times, most recently
from
eb0b54d to
67e613f
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
from
67e613f to
0e16e23
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
6 times, most recently
from
9639f15 to
5d609fa
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
from
5d609fa to
7aa022c
Compare
JonasBa
force-pushed
the
jb/feat/precompile
branch
from
b00c478 to
d1cefd5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide precompiled binaries.
This PR fixes #49 by providing precompiled binaries for macos (x86 as there is no github runner for arm yet), windows and linux. Since binary sizes are small, we just ship them as part of the npm package. If build is not available after installing the package, the package will build from source.
This partially mitigates installation problems for some envs that may ship without the tooling required to build the bindings.