This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
feat(timestamps): more accurate timestamps #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously not collecting accurate timestamps in regards to when profiling was started/stopped relative to the transaction.
Since calling profile.GetStartTime() and profile->GetEndTime() do not return relative timestamps it is not suitable to use that data to determine the elapsed time between the start of transaction. Having a relative ts here would improve accuracy. For those reasons, we use process.hrtime to mark the start/stop timestamps of calls to startProfiling and stopProfiling.
We error on the safe side by placing the hrtime marker call after startProfiling which effectively means that our relative start time will be reported higher than it is, however this is beneficial as it allows us to monitor the delay to start/stop profiling which can be different depending on the v8::CpuProfilingLoggingMode used.
process.hrtime markers are added to following points in the transaction/profiling lifecycle.