This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
GitHub authentication #25
Open
nickbruun
wants to merge
7
commits into
getsentry:master
Choose a base branch
from
nickbruun:feature/github-auth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6aa5303
Add GitHub as authentication backend.
nickbruun 4ecf3d2
Allow for specification of PostgreSQL database template for testing.
nickbruun b90e0f2
Add configuration parsing of GitHub authentication.
nickbruun 3352119
Simplify handling of exchange errors.
nickbruun 5aad603
Abstract auth providers.
nickbruun 3b3e653
Refactor authentication provider to Flask extension.
nickbruun 5f44e45
Update to imports.
nickbruun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
from __future__ import absolute_import | ||
|
||
from .exceptions import AccessDeniedError, ProviderConfigurationError # noqa | ||
from .providers import GoogleOAuth2Provider, GitHubOAuth2Provider | ||
|
||
|
||
class Auth(object): | ||
"""Flask extension for OAuth 2.0 authentication. | ||
|
||
Assigns the configured provider to the ``auth_provider`` key of | ||
``app.state`` when initialized. | ||
""" | ||
|
||
def __init__(self, app=None): | ||
if app is not None: | ||
self.init_app(app) | ||
|
||
def init_app(self, app): | ||
# For compatibility with previous versions of Freight, default to using | ||
# Google as the authentication backend. | ||
backend = app.config.get('AUTH_BACKEND') | ||
if not backend: | ||
backend = 'google' | ||
|
||
# Resolve the provider setup function. | ||
try: | ||
provider_cls = { | ||
'google': GoogleOAuth2Provider, | ||
'github': GitHubOAuth2Provider, | ||
}[backend] | ||
except KeyError: | ||
raise RuntimeError('invalid authentication backend: %s' % | ||
(backend)) | ||
|
||
# Set up the provider. | ||
if not hasattr(app, 'state'): | ||
app.state = {} | ||
|
||
app.state['auth_provider'] = provider_cls.from_app_config(app.config) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
from __future__ import absolute_import | ||
|
||
|
||
class AccessDeniedError(Exception): | ||
"""Access denied. | ||
|
||
Raised if authentication with the backend succeeded but the user is not | ||
allowed access by configuration. | ||
""" | ||
|
||
pass | ||
|
||
|
||
class ProviderConfigurationError(Exception): | ||
"""Provider configuration error. | ||
""" | ||
|
||
pass |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good, and if we want to extend it in the future we can just have AUTH_BACKEND support a full class path or similar