fix(cloudbuild): path for log files was constructed incorrectly

getsentry · Apr 2, 2019 · c79930a · c79930a
1 parent d1e8305
commit c79930a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/freight/checks/cloudbuilder.py b/freight/checks/cloudbuilder.py
@@ -83,7 +83,7 @@ def check(self, app, sha, config):
         }
 
         if build_status == "FAILURE":
-            build_logtext = u"https://storage.googleapis.com/{}/log-{}.txt".format(
+            build_logtext = u"https://storage.googleapis.com/{}log-{}.txt".format(
                 build_logs[5:], build_id
             )
             log = http.get(build_logtext, headers=headers)

diff --git a/tests/checks/test_cloudbuilder.py b/tests/checks/test_cloudbuilder.py
@@ -101,7 +101,7 @@ def test_build_fail(self):
         responses.add(
             responses.GET,
             u"https://storage.googleapis.com/{build_logs}/log-{build_id}.txt".format(
-                build_logs="mycoolproject.cloudbuild-logs.googleusercontent.com",
+                build_logs="mycoolbucket/mycoolproject/",
                 build_id="failed_build_id",
             ),
             body=dedent(failed_log_text),