meta: update handler 2022-12-12 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I39e459f519922433de82c62385d08c6db34328f0 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3964165 Reviewed-by: Mike Frysinger <[email protected]>
Change-Id: I0049bb92658b4226e32783ad4d8271787deef5f3 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3964166 Reviewed-by: Mike Frysinger <[email protected]>
Change-Id: I019cc9ffd66850ec5259f6dfcd9af8ac6c37d2c0 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3938926 Reviewed-by: Manoj Gupta <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
Fixed: chromium:1378800 Change-Id: I8215c091c72e796b1683753e2512d6e6adc4167f Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3984802 Reviewed-by: Joshua Peraza <[email protected]>
This is similar to the Windows change at https://chromium-review.googlesource.com/c/breakpad/breakpad/+/773418/ When a `Module` is created with `enable_multiple_field_` = true, all FUNCs and PUBLICs that share the same address will be collapsed into a single entry, and that entry will be marked with `m` for multiple in the final output. `enable_multiple_field_` is temporary just in case people are depending on the current behavior. Support for `dump_syms` executables will be added in a follow-up. Bug: google-breakpad:751 Change-Id: I631a148ed00138924c7bcb5ad6db8b9a6610dd03 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3905122 Reviewed-by: Mark Mentovai <[email protected]>
A couple of pointer parameters should be references instead. Change-Id: Ic1850d9330194374f7fe2108815267ede6f3ca32 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4021971 Reviewed-by: Joshua Peraza <[email protected]>
The way this was originally written blows up on large enough targets (like...Chromium :/). This change adds a set for amortized constant time lookup of whether a FUNC already exists at a given address. Bug: google-breakpad:751 Change-Id: I10a322da70f769c106e1e5f5b2dc3dc3f79444fd Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4031580 Reviewed-by: Mark Mentovai <[email protected]>
- We were appending a CRLF to uploaded files, which is okay for Breakpad symbols but breaks binaries (PE/PDB). - Removed the CRLF after files in the request body to fix issue. Tested with Breakpad, PE, and PDB uploads. Change-Id: I95ee7c51bf981cdb2e55cc720a7813cf7afa21ce Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4038506 Reviewed-by: Joshua Peraza <[email protected]> Reviewed-by: Zequan Wu <[email protected]>
…nversion. Change-Id: I8948e1aba598d42369d70ca1cc1168ce3841ab40 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4038509 Reviewed-by: Zequan Wu <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
Bug: 1385147 Change-Id: I69ebfa1adbc1c2a17decf0079812c4f507e3332c Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4046961 Reviewed-by: Mike Frysinger <[email protected]>
As the conditionals and targets was becoming quite hard to grasp with lots of conditionals applied unnecessarily to target properties, there were issues with targets being defined without any sources. This commit fixes that while restructuring the Makefile so that all targets are declared (conditionally if needed) upfront and then all the target properties are defined (source, flags, deps, etc.) Change-Id: I666d153c476fbf1aafabb89cee7af4eee5795ab6 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3928024 Reviewed-by: Mike Frysinger <[email protected]>
Bug: google-breakpad:751 Change-Id: I12afcc8399fa9808aace9f465622bd074eab13f4 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4034827 Reviewed-by: Mark Mentovai <[email protected]>
Chromium moved to GN a long time ago, and CrOS has never used this. Let's remove one of the build systems to make it easier on people. Especially since the GYP tool is completely unmaintained now. Change-Id: I0371ca1427811f307dc30f88ed6d1bf61d7fab89 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4054941 Reviewed-by: Mark Mentovai <[email protected]>
Bug: google-breakpad:751 Change-Id: I63a4d652413ef7311da7494fbd8fb816445eb353 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4089183 Reviewed-by: Mark Mentovai <[email protected]>
- Fix a test build failure introduced by https://chromium.googlesource.com/breakpad/breakpad/+/cc7abac08b0c52e6581b9c9c4226816b17a4c26d. - Use strcmp from <string> instead of std::strcmp from <cstring>. Bug: google-breakpad:867 Change-Id: I8dcbc7d5ac8ea799b4d5287ddbbf5d6626992123 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4095054 Reviewed-by: Mike Frysinger <[email protected]>
|
@Swatinem pls have a look. Practically no changes affect the sentry-native use case. |
Swatinem
approved these changes
Dec 12, 2022
|
Hi @Swatinem, I still cannot merge on this repo. Let's get this on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.