Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trino query runner #5405

Closed
wants to merge 1 commit into from
Closed

Add Trino query runner #5405

wants to merge 1 commit into from

Conversation

song9446
Copy link

@song9446 song9446 commented Feb 24, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Trino query runner workaround code. I've used it for a while, and decided to share with other people.

Most of the codes are shamelessly copied from the prestodb query runner code.

The authentication part has not been properly tested and may not work as expected.

Related Tickets & Documents

#5380

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@arikfr
Copy link
Member

arikfr commented Mar 12, 2021

Thank you, @song9446 ! We're about to merge the implementation from #5411 so going to close this one. It's not entirely clear to me if the behavior implemented in extract_columns_from_type_string required there, but if it is - maybe you can implement it on top of the implementation in #5411?

@arikfr arikfr closed this Mar 12, 2021
@song9446
Copy link
Author

@arikfr The extract_columns_from_type_string function parses the nested schema of the table into a list of columns which have a flattened path instead of a name, making the sub-columns visible in the schema explorer on the redash query page.

I strongly need this functionality because my dataset has a complex nested schema, but this behavior is not well defined in redash side, so I'll wait for the official nested field explorer support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants