Reduce RQ status load time #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 17, 2019
| @@ -155,7 +155,7 @@ def rq_queues(): | |||
| q.name: { | |||
| 'name': q.name, | |||
| 'started': fetch_jobs(q, StartedJobRegistry(queue=q).get_job_ids()), | |||
| 'queued': fetch_jobs(q, q.job_ids) | |||
| 'queued': len(q.job_ids) | |||
There was a problem hiding this comment.
Does q.job_ids include queued and started?
There was a problem hiding this comment.
RQ does an LPOP when it starts executing a job so q.job_ids won't include started ones (instead, they are moved to rq:wip:..., which is observed by the StartedJobRegistry).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The RQ job status page was loading job information for all queued jobs, but for those, we only care about the amount. This PR fixes this.
Running a small benchmark - for 60k queued jobs, this PR has reduced the load time from approx 34 seconds to 2 seconds.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)