Align content vertically in restricted widget type #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This displays content in restricted widget type vertically centered. It sets the flex property for the scrollbox back to default initial value by removing `body-row-auto` class. Fixes getredash#3949
ranbena
approved these changes
Aug 11, 2019
1 task
gabrieldutra
added a commit
that referenced
this pull request
Aug 18, 2019
arikfr
pushed a commit
that referenced
this pull request
Sep 20, 2019
* Improve sizing for Number inputs Co-Authored-By: Ran Byron <[email protected]> * Migrate WidgetDialog * Start migrating Widget * Update textbox to use HtmlContent * QueryLink migration and some updates * Add visualization rendering * Render widget * Add delete button * Update AutoHeight * Add widget bottom * Add Drodpown button * Split Widget component * Update with #4056 and trigger netlify * In progress: use composition * Add header and footer * Update widget actions positioning * Re-render when refreshing from widget * Add workaround to force DashboardGrid re-render * VisualizationWidgetFooter component * VisualizationWidget menu * Separate RestrictedWidget * Update tests * Update margin for Parameters * Remove widget files * Revert "Improve sizing for Number inputs" This reverts commit a02ce8f. * Some cleanup * Move refresh logic to the Dashboard * Add loadingWidgets logic to the public dashboard * Add onLoadWidget * Remove parameter from URL when empty * Recreate widget array instead of loadingWidgets * Add comment about re-rendering + whitespace missing * CR changes * Use plain html instead of string syntax Co-Authored-By: Ran Byron <[email protected]>
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This displays content in restricted widget type vertically centered.
It sets the flex property for the scrollbox back to default initial value
by removing
body-row-autoclass.Related Tickets & Documents
#3949
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Mobile
Desktop
