Remove legacy session identifier support #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Jun 2, 2019
redash/authentication/__init__.py
Outdated
| user = models.User.get_by_id_and_org(user_id, org) | ||
| if user.is_disabled or user.get_id() != user_id_with_identity: | ||
| return None | ||
|
|
||
| return user | ||
| except models.NoResultFound: | ||
| except (models.NoResultFound, Exception): |
There was a problem hiding this comment.
Maybe we should only catch SyntaxError instead of Exception here?
There was a problem hiding this comment.
Well it could be either a ValueError when user_id_with_identity isn't hyphenated or a AttributeError when user_id_with_identity is an integer, so I thought I'd just catch all. I could wrap only line 47, which might make it more explanatory.
There was a problem hiding this comment.
My concern here is that it might swallow some unrelated exceptions and make debugging future issues harder. Aside from this there is not much harm in catching Exception here.
|
👍 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* remove legacy session identifier support * remove redundant test * redirect to login to support any invalid session identifiers * be more specific with caught errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Users who logged in prior to #3174 going live have their (integer) user_id as their session user identifier.
This no longer needs to be supported.
Related Tickets & Documents
#3174
Mobile & Desktop Screenshots/Recordings (if there are UI changes)