Unify query based dropdown population#3337

Merged

rauchy merged 87 commits intomasterfrom unify-query-based-dropdown-population

Feb 10, 2019

+103-50

Commits on Dec 27, 2018

stop testing collect_query_parameters, it's an implementation detail
Omer Lachish
committed
add tests for missing_query_params
Omer Lachish
committed

Commits on Dec 30, 2018

rename SQLQuery -> ParameterizedSqlQuery
Omer Lachish
committed
rename sql_query.py to parameterized_query.py
Omer Lachish
committed
split to parameterized queries and parameterized SQL queries, where
Omer Lachish
committed
Merge branch 'tests-for-find-missing-params' into run-tree-validations-only-on-sql-dialects
Omer Lachish
committed

Commits on Dec 31, 2018

Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
committed
move missing parameter detection to ParameterizedQuery
Omer Lachish
committed

Commits on Jan 1, 2019

get rid of some old code
Omer Lachish
committed
fix tests
Omer Lachish
committed
Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
authored
set syntax to custom
Omer Lachish
committed
Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
committed
Merge branch 'run-tree-validations-only-on-sql-dialects' of github.com:getredash/redash into run-tree-validations-only-on-sql-dialects
Omer Lachish
committed

Commits on Jan 3, 2019

Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
committed

Commits on Jan 6, 2019

Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
authored

Commits on Jan 13, 2019

Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
authored

Commits on Jan 16, 2019

revert the max-age-related refactoring
Omer Lachish
committed
Merge branch 'master' into run-tree-validations-only-on-sql-dialects
Omer Lachish
authored
👋 tree validations 😢
Omer Lachish
committed
BaseQueryRunner is no longer a factory for ParameterizedQuery, for now
Omer Lachish
committed

Commits on Jan 17, 2019

Merge branch 'master' into validate-parameters
Omer Lachish
committed

Commits on Jan 20, 2019

Merge branch 'master' into validate-parameters
Omer Lachish
committed
add an endpoint for running a query by its id and (optional) parameters
Omer Lachish
committed
Merge branch 'master' into textless-query-result-endpoint
Omer Lachish
committed
Merge branch 'master' into textless-query-result-endpoint
Omer Lachish
authored
Merge branch 'textless-query-result-endpoint' into validate-parameters
Omer Lachish
committed
adds parameter schema to ParameterizedQuery
Omer Lachish
committed
adds parameter schema validation (currently for strings)
Omer Lachish
committed
validate number parameters
Omer Lachish
committed
validate date parameters
Omer Lachish
committed
validate parameters on POST /api/queries/<id>/results
Omer Lachish
committed

Commits on Jan 21, 2019

validate enum parameters
Omer Lachish
committed
validate date range parameters
Omer Lachish
committed
validate query-based dropdowns by preprocessing them at the handler
Omer Lachish
committed
change _is_date_range to be a tad more succinct
Omer Lachish
committed
a single assignment with a map is sufficiently explanatory
Omer Lachish
committed
Update redash/utils/parameterized_query.py

jezdez
and
rauchy
authored
Update redash/utils/parameterized_query.py

jezdez
and
rauchy
authored
Update redash/utils/parameterized_query.py

jezdez
and
rauchy
authored
Update redash/utils/parameterized_query.py

jezdez
and
rauchy
authored
Update redash/handlers/query_results.py

jezdez
and
rauchy
authored
Update redash/utils/parameterized_query.py

jezdez
and
rauchy
authored
build error message inside the error
Omer Lachish
committed
support all types of numbers as number parameters
Omer Lachish
committed
check for permissions when populating query-based dropdowns
Omer Lachish
committed

Commits on Jan 23, 2019

Merge branch 'master' into textless-query-result-endpoint
Omer Lachish
committed
check for access to query before running it
Omer Lachish
committed
Merge branch 'master' into validate-parameters
Omer Lachish
committed
check for empty rows when populating query-based enums
Omer Lachish
committed
don't bother loading query results if user doesn't have access
Omer Lachish
committed
💥 on unexpected parameter types
Omer Lachish
committed
parameter schema default is a list, not a dictionary
Omer Lachish
committed
Merge branch 'textless-query-result-endpoint' into validate-parameters
Omer Lachish
authored
Merge branch 'master' into validate-parameters
Omer Lachish
committed
Merge branch 'validate-parameters' of github.com:getredash/redash into validate-parameters
Omer Lachish
committed
fix a totally unrelated typo
Omer Lachish
committed

Commits on Jan 24, 2019

remove redundant null guards
Omer Lachish
committed
introduce /dropdown.json endpoint with dummy data
Omer Lachish
committed
wire frontend to /dropdown.json
Omer Lachish
committed
always return name/value combos from /dropdown.json
Omer Lachish
committed
load actual data into /dropdown.json
Omer Lachish
committed
pluck correct values for name and value
Omer Lachish
committed
reuse dropdwon plucking logic in QueryResultResource
Omer Lachish
committed
simplify _get_dropdown_values
Omer Lachish
committed
when doing parameter validation, we only care about the value and not
Omer Lachish
committed
Merge branch 'validate-parameters' into unify-query-based-dropdown-population
Omer Lachish
committed
rename dropdown to dropdownOptions
Omer Lachish
committed

Commits on Jan 27, 2019

Merge branch 'master' into unify-query-based-dropdown-population
Omer Lachish
committed
move dropdown_values to utils/parameterized_query.py
Omer Lachish
committed
stop converting queries to enums and encapsulate the work inside
Omer Lachish
committed
re-order arguments by importance
Omer Lachish
committed
test query parameter validation
Omer Lachish
committed
Merge branch 'master' into validate-parameters
Omer Lachish
committed
Merge branch 'validate-parameters' into unify-query-based-dropdown-population
Omer Lachish
committed

Commits on Jan 28, 2019

tests for dropdown_values logic
Omer Lachish
committed
remove .json suffix to the dropdown endpoint
Omer Lachish
committed

Commits on Jan 29, 2019

Merge branch 'master' into unify-query-based-dropdown-population
Omer Lachish
committed
allow BaseResource to handle JSON stuff
Omer Lachish
committed
move _pluck_name_and_value outside its containing method
Omer Lachish
committed
case-insensitive lookup when plucking name and value
Omer Lachish
committed

Commits on Jan 30, 2019

separate concerns and simplify test isolation for dropdown_values
Omer Lachish
committed
pick the default column according to the order specified in the query
Omer Lachish
committed
use current_org instead of passing org
Omer Lachish
committed

Commits on Feb 6, 2019

Merge branch 'master' into unify-query-based-dropdown-population
Omer Lachish
committed

Commits on Feb 10, 2019

Merge branch 'master' into unify-query-based-dropdown-population
Omer Lachish
committed
test that user has access to the query when calling the /dropdown
Omer Lachish
committed