Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a visualisation after running a query the query results are deleted #3372

Closed
ifeldmanAtlassian opened this issue Jan 30, 2019 · 1 comment
Assignees

Comments

@ifeldmanAtlassian
Copy link

We are testing the latest stable version of redash (6.0.0+b10818 (7fa6665)
Found a regression when creating a new visualization, to reproduce:
0. Open a new browser tab and log into redash

  1. Run a query
  2. Create a new visualization
  3. The X & Y drop downs are empty
  4. When you cancel the visualization creation you see that the query results disappeared

Note - the issue occurs only when you run redash for the first time on a new session

@arikfr
Copy link
Member

arikfr commented Feb 3, 2019

The issue isn't with a specific visualization, but with the query losing reference to the query result.

I think the issue happens because we don't take reference to the query result from the UI, so when first saving the query it gets saved without a query result reference (latest_query_data_id):

for field in ['id', 'created_at', 'api_key', 'visualizations', 'latest_query_data', 'last_modified_by']:
query_def.pop(field, None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants