remove the annoying quoted title from EmptyState (#4168)

getredash · Sep 22, 2019 · ed22b63 · ed22b63
1 parent d636b29
commit ed22b63
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/client/app/components/empty-state/EmptyState.jsx b/client/app/components/empty-state/EmptyState.jsx
@@ -40,7 +40,7 @@ Step.defaultProps = {
 
 export function EmptyState({
   icon,
-  title,
+  header,
   description,
   illustration,
   helpLink,
@@ -75,7 +75,7 @@ export function EmptyState({
   return (
     <div className="empty-state bg-white tiled">
       <div className="empty-state__summary">
-        {title && <h4>{title}</h4>}
+        {header && <h4>{header}</h4>}
         <h2>
           <i className={icon} />
         </h2>
@@ -148,7 +148,7 @@ export function EmptyState({
 
 EmptyState.propTypes = {
   icon: PropTypes.string,
-  title: PropTypes.string,
+  header: PropTypes.string,
   description: PropTypes.string.isRequired,
   illustration: PropTypes.string.isRequired,
   helpLink: PropTypes.string.isRequired,
@@ -161,7 +161,7 @@ EmptyState.propTypes = {
 
 EmptyState.defaultProps = {
   icon: null,
-  title: null,
+  header: null,
 
   onboardingMode: false,
   showAlertStep: false,

diff --git a/client/app/pages/home/home.html b/client/app/pages/home/home.html
@@ -21,7 +21,7 @@
     <a ng-click="$ctrl.verifyEmail()">Resend email</a>.
   </div>
   <empty-state
-    title="'Welcome to Redash 👋'"
+    header="'Welcome to Redash 👋'"
     description="'Connect to any data source, easily visualize and share your data'"
     illustration="'dashboard'"
     help-link="'https://redash.io/help/user-guide/getting-started'"