when working with a schema, fail in the case that there are parameters (

#3452)

which are not part of the schema

redash/utils/parameterized_query.py

@@ -96,10 +96,13 @@ def apply(self, parameters):
         return self
 
     def _valid(self, name, value):
+        if not self.schema:
+            return True
+
         definition = next((definition for definition in self.schema if definition["name"] == name), None)
 
         if not definition:
-            return True
+            return False
 
         validators = {
             "text": lambda value: isinstance(value, basestring),

tests/utils/test_parameterized_query.py

@@ -45,6 +45,13 @@ def test_handles_objects(self):
         })
         self.assertEqual(set([]), query.missing_params)
 
+    def test_raises_on_parameters_not_in_schema(self):
+        schema = [{"name": "bar", "type": "text"}]
+        query = ParameterizedQuery("foo", schema)
+
+        with pytest.raises(InvalidParameterError):
+            query.apply({"qux": 7})
+
     def test_raises_on_invalid_text_parameters(self):
         schema = [{"name": "bar", "type": "text"}]
         query = ParameterizedQuery("foo", schema)