Support additional docker flags and remove legacy docker build driver #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
carolynvs
force-pushed
the
buildkit-flags
branch
from
ad3c275 to
88cbf88
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carolynvs
force-pushed
the
buildkit-flags
branch
2 times, most recently
from
f8317c1 to
910e3a1
Compare
carolynvs
changed the title
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carolynvs
force-pushed
the
buildkit-flags
branch
from
910e3a1 to
04f099f
Compare
|
/azp run porter-integration |
|
Pull request contains merge conflicts. |
carolynvs
force-pushed
the
buildkit-flags
branch
from
04f099f to
d3a45c9
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This adds support for the following docker flags: --build-arg: Pass build arguments that can be used in the template dockerfile --ssh: Provide a ssh configuration to the container while building --secret: Provide a secret to the container while building --no-cache: Build the image and do not use cached layers. It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used. After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs. Closes getporter#1769 Closes getporter#1941 Signed-off-by: Carolyn Van Slyck <[email protected]>
Default to buildkit only and remove the docker build driver Keep the build driver config option, in case we ever get creative in the future Closes getporter#1954 Signed-off-by: Carolyn Van Slyck <[email protected]>
If a template that was previously written for legacy docker is used now that we only support buildkit, use dockerfile syntax 1.4.0 and prepend that to their template so that when we inject things like `COPY --link` their bundle still builds. Signed-off-by: Carolyn Van Slyck <[email protected]>
carolynvs
force-pushed
the
buildkit-flags
branch
from
d3a45c9 to
f1912a1
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Apr 5, 2022
|
@vdice The example sort of snuck in 😂 It's going to be the source for an upcoming blog post telling people about the new buildkit features. I'll add a follow-up to make it a proper example linked from our examples page too though! https://release-v1.porter.sh/examples. |
Closed
This was referenced Apr 5, 2022
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Support additional docker flags
This adds support for the following docker flags:
--build-arg: Pass build arguments that can be used in the template dockerfile
--ssh: Provide a ssh configuration to the container while building
--secret: Provide a secret to the container while building
--no-cache: Build the image and do not use cached layers.
It also fixes how we call the docker buildx plugin so that user configuration, such as a proxy, is used.
After upgrading to a new version of buildx, I was also able to pick up a fix for pretty printing the progress to stderr, while capturing the plaintext output to the logs.
The dockerfile syntax 1.4.0 is officially released, so I've also edited our templates to use the official version
# syntax=docker/dockerfile-upstream:1.4.0Remove experimental flag for build drivers
Default to buildkit only and remove the docker build driver. Keep the build driver config option, in case we ever get creative in the future
What issue does it fix
Closes #1769 (support new buildkit flags)
Closes #1954 (make buildkit the default driver and get rid of legacy docker)
Closes #1941 (load docker config)
Notes for the reviewer
🚨 This must be rebased before merging, it relies on #1998I kept the configuration infra in place in case we ever add a new build driver in the future. But the flag --driver is now hidden for the build command since there's no reason to set it at the moment. I also kept the experimental config documentation and just let people know it's not needed anymore. I felt that people who were used to the flag would be confused to have its doc disappear without explanation.
Long term maybe we need a page/section of "promoted" experimental features.
Checklist
Reviewer Checklist