Porter triggers autobuild when detecting that invocation image does not exist #1828
Conversation
joshuabezaleel
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
…ot exist Signed-off-by: joshuabezaleel <[email protected]>
joshuabezaleel
force-pushed
the
autobuild-invocation-image-not-exist
branch
from
cda0121 to
dc5e6c9
Compare
|
Hi @carolynvs ! 😄 So basically I added the method to check whether an invocation image exists on the RegistryProvider since the docker client is only available on the RegistryProvider and use that particular method to set the Along with this comment, I attached the video demo of it. The porter of porter-autobuild-invocation-image-newest.mp4 |
There was a problem hiding this comment.
This is really close. Most of my comments are about how to get the code a bit closer to fitting in with the rest of porter's conventions. Since you are interested in eventually being a maintainer, I wanted to give you more information about how we have been doing things.
…along with some explanation comment. 2. Use invocationImage directly as an input to list images 3. Wrap error from Docker SDK and remove error wrap on stamp.go 4. Fix wording to "local image cache" from "host registry" Signed-off-by: joshuabezaleel <[email protected]>
joshuabezaleel
force-pushed
the
autobuild-invocation-image-not-exist
branch
from
98a1145 to
3b48c78
Compare
|
The workflow should still work just fine as the attached video below after the recent commit even though I'm not sure why did it take so long to build the image, perhaps it was just my machine or the internet connection. Since I'm new to the open source world I have to be honest that I often feel anxious as to making beginner mistakes here and there and will burden the team/maintainer but reading your code review has always been a delight as it has always been so thoughtful. Thank you lots, @carolynvs ! 😄 |
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ot exist (getporter#1828) * Porter triggers autobuild when detecting that invocation image does not exist Signed-off-by: joshuabezaleel <[email protected]> * 1. Change function name from IsInvocationImagExists to IsImageCached along with some explanation comment. 2. Use invocationImage directly as an input to list images 3. Wrap error from Docker SDK and remove error wrap on stamp.go 4. Fix wording to "local image cache" from "host registry" Signed-off-by: joshuabezaleel <[email protected]>
What does this change
Check whether the invocation image exists in the host registry and trigger autobuild of the image by setting the return value of
IsBundleUpToDatetofalse.What issue does it fix
Closes #1756
Checklist