-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependencies client-go and controller-runtime #219
Conversation
Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
ba0a80a
to
093c00f
Compare
Signed-off-by: Troy Connor <[email protected]>
093c00f
to
ffb6560
Compare
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 76.67% 69.66% -7.01%
==========================================
Files 13 13
Lines 1556 1556
==========================================
- Hits 1193 1084 -109
- Misses 230 352 +122
+ Partials 133 120 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Troy Connor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will ya throw a link to the issue to make codecov happy eventually
#220 <-- Issue link. |
What does this change
This updates client-go to 0.28.3-alpha while also having to update controller-runtime to 0.15.0
When updating it produced the following error:
Both releases here:
kubernetes issue with why we need client-go 0.28.0-alpha
controller-runtime
What issue does it fix
Closes # Dependabot PR
Dependabot PR that tried to do this automatically went to client-go 0.27.0 but we have to skip that to get this to work with the above issues.
Notes for the reviewer
Because of the breaking change of controller-runtime, there are some adjustments added to the tests to get them to pass.
WithStatusSubResource(...)
to the setup functions in the test or else we can't update the status on the reconcilepvc, pv
) as the object tracker can create them in the fake client but not list/get them during operations.Checklist