feat: generate kube manifests #560
Draft
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewWinterman
approved these changes
Jan 28, 2025
| find ./deployments/libs -name '*.libsonnet' -exec jsonnetfmt -i {} + | ||
| fi | ||
|
|
||
| generate '{"name":"bento1a", "cluster":"none", "region":"none", "channel":"white", "environment":"development", "dev_email":"stub@email"}' |
There was a problem hiding this comment.
You may want to use disco to retrieve the canonical list of bentos for future proofing. Just a suggestion
There was a problem hiding this comment.
Thanks, I don't have time for that right now, but I might come back to that later.
|
We need to wait for https://outreach-io.atlassian.net/browse/COR-6560 to be resolved. Otherwise this would trigger Pen test. |
auto-merge was automatically disabled
January 30, 2025 15:13
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
The intention of this tooling is to be able to easily see and track in history what the changes in jsonnet files in the PRs actually do.
Because in lot of cases it's not so obvious and really small mistake can have significant impacts.
Jira ID
[XX-XX]
Notes for your reviewers