feat: allow overriding golangci-lint version with env var #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkinkead
reviewed
Apr 23, 2023
ensure that version is installed
kaldorn
changed the title
jaredallard
reviewed
Apr 24, 2023
| # shellcheck disable=SC2155 | ||
| local version="$(asdf_get_version_from_devbase "$tool")" | ||
| # Allow overriding the golangci-lint version with an environmental variable | ||
| if [[ $tool = "golangci-lint" ]] && [[ "${GOLANGCI_LINT_VER}" ]]; then |
There was a problem hiding this comment.
Putting a version in the top block in the .tool-versions should already be overriding... so I'm not really sure this is required.
There was a problem hiding this comment.
Talking more offline -- realized that this is required for devbase managed versions. We need the ability for the .tool-versions in the root of the repo to override the devbase specified version, which isn't a thing today.
|
Replacing with #536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Allows a repo to have a
.tool-versionsfor golangci-lint, specificaly. This is only needed until this issue is fixed: golangci/golangci-lint#3711Jira ID
[XX-XX]
Notes for your reviewers