Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip child-vaccination smoke test #206

Closed
wants to merge 1 commit into from

Conversation

eyelidlessness
Copy link
Member

Part of #205.

I really don't want to risk forgetting that this test is skipped. So I've conditioned the skip to be within a two week window, which we can easily extend as needed. I also included a non-code escape hatch to quickly unblock CI if rerun.

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: ad9837e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eyelidlessness
Copy link
Member Author

After opening this I realized the form definition itself is the culprit. I'll update the issue with a more detailed explanation for posterity. For this PR, I think it's best to close. I'll have a replacement PR soon which takes the tack we discussed in Slack yesterday: creating an alternate form definition/test with a change to avoid the pathological case triggered by the form design as-is. I expect that replacement PR will also involve updating the child vaccination smoketest to account for further progress, since it was indexed-repeat and then jr:count blocking its progress previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant