Skip to content
This repository has been archived by the owner on Apr 9, 2021. It is now read-only.

Fix: Add Exit Toast #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Add Exit Toast #375

wants to merge 2 commits into from

Conversation

prit29
Copy link

@prit29 prit29 commented Mar 22, 2020

Closes #372

What has been done to verify that this works as intended?

I tested it on Android 9.0.

Why is this the best possible solution? Were any other approaches considered?

As comments in this issue, I figure out that exit confirmation is good, but not by dialog so I'm doing this by an easy approach.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No regression risks

Before submitting this PR, please make sure you have:

  • run ./gradlew checkCode and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.

@prit29 prit29 closed this Mar 22, 2020
@prit29 prit29 reopened this Mar 22, 2020
Copy link
Contributor

@ajay-prabhakar ajay-prabhakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are getting Do not use Windows line endings In windows android studio will have the new lines at the end you can change that in settings for that please follow these steps and run once again

  • Change line endings to Unix. Settings > Editor > Code Style > General (tab) > Line Separator :: Unix and Mac OS (\n)
  • Configure the Terminal environment settings for Java: Settings > Tools > Terminal JAVA_HOME=C:/Program Files/Android/Android Studio/jre
  • Accept SDK licenses if necessary. Run from the Terminal in Android Studio using your own username AppData path: "C:\Users<username>\AppData\Local\Android\Sdk\tools\bin\sdkmanager.bat" --licenses
  • To be able to run / debug tests using Android Studio, edit the JUnit configuration to use a classpath file instead of a bloated classpath string (which maxes out the tiny Windows limit for environment variables): Run > Edit Configurations... > (left pane)Templates > Android JUnit > (right pane)Shorten command line: classpath file

@@ -184,4 +184,6 @@
<string name="finalized_on_date_at_time">\'Finalized on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html -->
<string name="sent_on_date_at_time">\'Sent on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html -->
<string name="sending_failed_on_date_at_time">\'Sending failed on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html -->

<string name="exit_toast">Press BACK again to exit program</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of program please give app

@ajay-prabhakar
Copy link
Contributor

@pritsahkar You still can work on the previous PR, if you got stuck at anywhere we are happy to help you
As you opened new PR please close the previous one

@prit29
Copy link
Author

prit29 commented Mar 23, 2020

you are getting Do not use Windows line endings In windows android studio will have the new lines at the end you can change that in settings for that please follow these steps and run once again

  • Change line endings to Unix. Settings > Editor > Code Style > General (tab) > Line Separator :: Unix and Mac OS (\n)

@Chromicle I already do it, but still give an error, I think I should change all files CRLF to LF and add a commit... and thanks for your suggestions & response

@ajay-prabhakar
Copy link
Contributor

@pritsahkar are you still working on this?

@ajay-prabhakar
Copy link
Contributor

@huangyz0918 as there is no response I think you close this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add exit confirmation dialog
2 participants