-
Notifications
You must be signed in to change notification settings - Fork 73
Fix: Add Exit Toast #375
base: master
Are you sure you want to change the base?
Fix: Add Exit Toast #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are getting Do not use Windows line endings
In windows android studio will have the new lines at the end you can change that in settings for that please follow these steps and run once again
- Change line endings to Unix. Settings > Editor > Code Style > General (tab) > Line Separator :: Unix and Mac OS (\n)
- Configure the Terminal environment settings for Java: Settings > Tools > Terminal JAVA_HOME=C:/Program Files/Android/Android Studio/jre
- Accept SDK licenses if necessary. Run from the Terminal in Android Studio using your own username AppData path: "C:\Users<username>\AppData\Local\Android\Sdk\tools\bin\sdkmanager.bat" --licenses
- To be able to run / debug tests using Android Studio, edit the JUnit configuration to use a classpath file instead of a bloated classpath string (which maxes out the tiny Windows limit for environment variables): Run > Edit Configurations... > (left pane)Templates > Android JUnit > (right pane)Shorten command line: classpath file
@@ -184,4 +184,6 @@ | |||
<string name="finalized_on_date_at_time">\'Finalized on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html --> | |||
<string name="sent_on_date_at_time">\'Sent on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html --> | |||
<string name="sending_failed_on_date_at_time">\'Sending failed on\' EEE, MMM dd, yyyy \'at\' HH:mm</string> <!-- http://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html --> | |||
|
|||
<string name="exit_toast">Press BACK again to exit program</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of program please give app
@pritsahkar You still can work on the previous PR, if you got stuck at anywhere we are happy to help you |
@Chromicle I already do it, but still give an error, I think I should change all files CRLF to LF and add a commit... and thanks for your suggestions & response |
@pritsahkar are you still working on this? |
@huangyz0918 as there is no response I think you close this |
Closes #372
What has been done to verify that this works as intended?
I tested it on Android 9.0.
Why is this the best possible solution? Were any other approaches considered?
As comments in this issue, I figure out that exit confirmation is good, but not by dialog so I'm doing this by an easy approach.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No regression risks
Before submitting this PR, please make sure you have:
./gradlew checkCode
and confirmed all checks still pass OR confirm CircleCI build passes