This repository has been archived by the owner on Apr 9, 2021. It is now read-only.
Stops app crash on entering received forms #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shobhitagarwal1612 @lakshyagupta21 please review it, thank you! |
shobhitagarwal1612
suggested changes
Apr 4, 2019
skunkworks_crow/build.gradle
Outdated
| @@ -31,6 +31,7 @@ dependencies { | |||
| testImplementation 'junit:junit:4.12' | |||
| androidTestImplementation 'androidx.test:runner:1.1.1' | |||
| androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0-alpha4' | |||
| implementation 'com.google.android.material:material:1.0.0' | |||
There was a problem hiding this comment.
Please remove this. Dependency is already added
There was a problem hiding this comment.
Ohh! I did not see. I done
shobhitagarwal1612
approved these changes
Apr 4, 2019
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Apr 6, 2019
autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Apr 6, 2019
autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Apr 6, 2019
Added Flash light feature autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Made object name to camel case
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Apr 6, 2019
Added Flash light feature autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Made object name to camel case
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Apr 6, 2019
Added Flash light feature autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Made object name to camel case Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Changes for getodk#230 Changed QR code camel case Changed QR code camel case
ajay-prabhakar
added a commit
to ajay-prabhakar/share
that referenced
this pull request
Aug 21, 2019
Added Flash light feature autofills ignored removed empty line Added the flash feature added margin and made some changes Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Removed unused changes Removed unused changes Introduced flashlight made maifest changes Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed Checkstyle changed changed to QRcode Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Made object name to camel case Fix crash on start Also removes duplicate write permissions requests Stop app crash on entering received forms (getodk#237) Improve UX for setting password (getodk#230) Changes for getodk#230 Changed QR code camel case Changed QR code camel case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
The app is crashing due to
android.support.design.widget.TextInputLayoutso I imported dependencies fromgoogle android materialand stopped the warning of
autofillHow does this change affect users?
App crash is not at all the good behavior, so removed that behavior
by directing into review form so the user can review the forms or view it on ODK collect
GIF
Before submitting this PR, please make sure you have:
./gradlew checkCodeand confirmed all checks still pass OR confirm CircleCI build passes