Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom Objects class for clients that use Java <1.7 #455

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

lognaturel
Copy link
Member

Addresses getodk/collect#3192

Adds a hash implementation to the custom Objects class introduced in #450 to support clients that use Java <1.7.

@lognaturel lognaturel requested a review from ggalmazor July 8, 2019 15:50
@codecov-io
Copy link

Codecov Report

Merging #455 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
- Coverage     49.03%   49.01%   -0.02%     
+ Complexity     2940     2939       -1     
============================================
  Files           246      246              
  Lines         13698    13699       +1     
  Branches       2650     2650              
============================================
- Hits           6717     6715       -2     
- Misses         6132     6134       +2     
- Partials        849      850       +1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/javarosa/core/model/FormIndex.java 48.93% <ø> (ø) 40 <0> (ø) ⬇️
src/main/java/org/javarosa/core/util/Objects.java 33.33% <0%> (-16.67%) 3 <0> (ø)
...a/org/javarosa/core/services/PrototypeManager.java 79.16% <0%> (-8.34%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196cd18...fbed249. Read the comment docs.

Copy link

@nribeka nribeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating an issue for the TODO I think will be a great addition to this PR :)

Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Monkey-patching Java in a controlled way! 😲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants