Fix list names with special characters #6520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this crash
Why is this the best possible solution? Were any other approaches considered?
I've just opted to quote the list names. I think a good follow up would be to use a safer mechanism to build SQL queries. Sadly, there's very little support for building complex queries with dynamic table/column names in the Android SDK itself, and I also haven't seen much in the way of third party libraries. We might have to roll our own solution.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?.
Should just allow list names with special characters (like
favourite-films
). It'd be good to do a full sweep of both dataset and property names to check that anything that can be created on Central is supported by Collect.Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest