Use parser to identify randomize
function and make meaningful seed out of text
#6478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
Upgrades JR to the latest master
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The randomize function now converts text strings to numbers other than 0. There's also been a change to how randomize in an itemset is represented in the cached form.
Do we need any specific form for testing your changes? If so, please attach one.
Forms with randomized choices. We have a lot of automated tests but it would be good to do some sanity checks with the forms that QA has. Because this changes the cached form representation, it would also be a good idea to load the form in the 2024.2 self-signed release build and then upgrade to this code.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/xforms-spec#318
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest