Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parser to identify randomize function and make meaningful seed out of text #6478

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lognaturel
Copy link
Member

@lognaturel lognaturel commented Oct 28, 2024

Why is this the best possible solution? Were any other approaches considered?

Upgrades JR to the latest master

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The randomize function now converts text strings to numbers other than 0. There's also been a change to how randomize in an itemset is represented in the cached form.

Do we need any specific form for testing your changes? If so, please attach one.

Forms with randomized choices. We have a lot of automated tests but it would be good to do some sanity checks with the forms that QA has. Because this changes the cached form representation, it would also be a good idea to load the form in the 2024.2 self-signed release build and then upgrade to this code.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

getodk/xforms-spec#318

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel marked this pull request as ready for review October 28, 2024 17:08
@grzesiek2010 grzesiek2010 merged commit c7c4719 into getodk:master Oct 28, 2024
6 checks passed
@lognaturel lognaturel deleted the jr-randomize branch October 28, 2024 17:24
@lognaturel lognaturel changed the title Upgrade JR to get randomize updates User parser to identify randomize function and make meaningful seed out of text Oct 28, 2024
@lognaturel lognaturel changed the title User parser to identify randomize function and make meaningful seed out of text Use parser to identify randomize function and make meaningful seed out of text Nov 8, 2024
@srujner
Copy link

srujner commented Nov 19, 2024

Tested with Success!

Verified on device with Android 14

Verified cases:

  • Forms with randomize choices: Question types, number, text strings;
  • Upgrading from the older version;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants