Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset savepoints when resetting instances #6468

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 23, 2024

Closes #6331

Why is this the best possible solution? Were any other approaches considered?

When resetting saved forms, we should also reset savepoints, as they are essentially saved forms too, making it logical to reset them together.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

I believe it should just fix the issue. I can't think of any big risk here so during testing we can focus on resetting saved forms.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review October 23, 2024 14:05
Copy link
Member

@seadowg seadowg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it needs to be rebased on top of master so that it's not readding back in the entities clearing (which was removed recently).

@grzesiek2010
Copy link
Member Author

This looks good, but it needs to be rebased on top of master so that it's not readding back in the entities clearing (which was removed recently).

Done.

@WKobus
Copy link

WKobus commented Nov 5, 2024

Tested with Success

Verified on device with Android 15

Verified cases:

@dbemke
Copy link

dbemke commented Nov 5, 2024

Tested with Success

Verified on device with Android 10

@seadowg seadowg merged commit 084ba2f into getodk:master Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Savepoint after resetting saved forms in project settings
4 participants