Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with offline layer covering points #6467

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 23, 2024

Closes #6401

Why is this the best possible solution? Were any other approaches considered?

The problem seems to be in Mapbox v11 see: mapbox/mapbox-maps-android#2389 (comment)
We have migrated from Mapbox 10 to 11 at the beginning of this release cycle and the only solution seems to be to get back to the old version and wait for a fix.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Getting back to the previously used Mapbox version (10) seems to be safe so we can focus on verifying that the issue no longer occurs.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review October 23, 2024 13:16
@grzesiek2010 grzesiek2010 requested a review from seadowg October 23, 2024 13:16
@seadowg
Copy link
Member

seadowg commented Oct 24, 2024

This is a small change, but individual maps implementations are untested, so I think it's best to get this to "behaviour verified" before merging.

@grzesiek2010 grzesiek2010 added the high priority Should be looked at before other PRs/issues label Oct 25, 2024
@dbemke
Copy link

dbemke commented Oct 28, 2024

Tested with Success!

Verified on a device with Android 10

Verified cases:

@WKobus
Copy link

WKobus commented Oct 28, 2024

Tested with Success!

Verified on a device with Android 15

@seadowg seadowg merged commit 15f6845 into getodk:master Oct 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offline layer covers points to select on Mapbox in Select one from map
4 participants