Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading geometryXPath in FormMetadataParser #6465

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 21, 2024

Closes #6450

Why is this the best possible solution? Were any other approaches considered?

The problem here was a bug in a recursive function that returned a wrong (null) value too early.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We should test forms with geopoints (those that display the map icon in the form list) under different configurations. In this case, the issue was that while the geopoint existed, the form had two groups, and it was placed in the second one. It would be helpful to create several forms with multiple groups, including nested ones, to thoroughly test these scenarios.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review October 21, 2024 12:04
@seadowg seadowg merged commit 14b8a59 into getodk:master Oct 22, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Oct 24, 2024

Tested with Success!

Verified on a device with Android 10

Verified cases:

@WKobus
Copy link

WKobus commented Oct 24, 2024

Tested with Success!

Verified on a device with Android 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing form map in All widgets/ All question type in "Start new form".
4 participants