Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating entities with missing labels #6458

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 16, 2024

Closes #6453

Why is this the best possible solution? Were any other approaches considered?

Not a lot to discuss here! I've just added to the already existing check that id isn't null.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Only forms that create/update entities should be affected.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 16, 2024 10:28
@grzesiek2010 grzesiek2010 merged commit 5dad7f4 into getodk:master Oct 16, 2024
6 checks passed
@seadowg seadowg deleted the missing-label branch October 17, 2024 07:26
@dbemke
Copy link

dbemke commented Oct 18, 2024

Tested with Success!

Verified on a device with Android 10

Verified cases:

@WKobus
Copy link

WKobus commented Oct 18, 2024

Tested with Success!

Verified on a device with Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity with missing label
4 participants