Reworked the banner in Ready to send screen using card view

[grzesiek2010]

Closes #6347

Why is this the best possible solution? Were any other approaches considered?

I tried making the custom ReadyToSendBanner view extend MaterialCardView, but it displayed gray background corners that I couldn't remove (this might be an Android bug). The solution was to wrap it in an additional FrameLayout, which may seem redundant at first glance.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The only change is the visual representation of the banner in Ready to send. Its functionality remains the same.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

• added or modified tests for any new or changed behavior
• run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
• added a comment above any new strings describing it for translators
• added any new strings with date formatting to DateFormatsTest
• verified that any code or assets from external sources are properly credited in comments and/or in the about file.
• verified that any new UI elements use theme colors. UI Components Style guidelines

[alyblenkin]

Could we left align all the text? Now that I'm seeing it, we have space to bring the icon and text closer together in the card. Otherwise, I think this looks really good and it anchors the page well.

[grzesiek2010]

Could we left align all the text? Now that I'm seeing it, we have space to bring the icon and text closer together in the card.

Just text or the icon too? If we align both it will be like this:

[alyblenkin]

Aligning the text was the only issue. I thought the icon looked fine before because the gap with the text looks too big.

[grzesiek2010]

@alyblenkin If only the text is aligned it will be like this, do you think it's better?

[alyblenkin]

The white space around the card makes it difficult to get the spacing right, but I don't want to spend too much more time on it because it's already looking good with the new card and app bar changes.

I think we keep the text aligned but add a bit more space between the icon and text (it almost gives the illusion that the icons are aligned).

[grzesiek2010]

@alyblenkin it's ready.

[srujner]

Tested with Success!

Verified on device with Android 10 and 13

Verified cases:

• Light and dark theme;
• Rotate the screen, minimize the app;
• Work towards Remove grey background on "Ready to send" screen #6347

[WKobus]

Tested with Success

Verified on device with Android 14