Code improvements for media file downloading #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
grzesiek2010
force-pushed
the
ODK-01-00
branch
from
9fd7312 to
14b7f57
Compare
seadowg
requested changes
Aug 12, 2024
grzesiek2010
force-pushed
the
ODK-01-00
branch
from
a4e0a1c to
553e46f
Compare
seadowg
requested changes
Aug 13, 2024
| DaggerUtils.getComponent(getContext()).inject(this); | ||
|
|
||
| String projectId = getProjectId(uri); | ||
| logServerEvent(projectId, AnalyticsEvents.INSTANCE_PROVIDER_UPDATE); |
There was a problem hiding this comment.
This analytics event should be deleted as well.
seadowg
approved these changes
Aug 13, 2024
seadowg
added
needs testing
high priority
|
Tested with Success! Verified on device with Android 14 Verified Cases:
|
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Aug 22, 2024
Code improvements for media file downloading
seadowg
added a commit
to seadowg/collect
that referenced
this pull request
Aug 23, 2024
Code improvements for media file downloading
grzesiek2010
pushed a commit
to grzesiek2010/collect
that referenced
this pull request
Oct 29, 2024
Code improvements for media file downloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this the best possible solution? Were any other approaches considered?
I've introduced sanitizing media file names and removed the support for
InstanceProvider#updateas we discussed with @seadowg.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The only thing that is worth testing here is downloading forms with media files.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest