Fix disappearing entity lists #6269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
commented
Jul 16, 2024
| @@ -57,7 +57,7 @@ abstract class EntitiesRepositoryTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `#save updates existing entity with matching id in different list`() { | |||
| fun `#save creates entity with matching id in different list`() { | |||
There was a problem hiding this comment.
This behaviour isn't something we have an opinion as far as I'm aware - we don't expect this to happen in real life, and if it did either behaviour feels reasonable.
grzesiek2010
approved these changes
Jul 17, 2024
|
Tested with Success! Verified on devices with Android: 10, 14 Verified Cases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6262
Closes #6163
Closes #6160
Why is this the best possible solution? Were any other approaches considered?
The solution itself is a little hacky, but the current entities storage implementation (
JsonFileEntitiesRepository) is about to go away, and the most important thing here in my opinion is to get a test in to verify correct behaviour in the new implementation.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Checking entity forms/projects here is probably the most important thing.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest