Use media file type to determine entity lists
#6249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
changed the title
mediaFile type to determine entity lists
seadowg
changed the title
mediaFile type to determine entity liststype to determine entity lists
grzesiek2010
requested changes
Jul 10, 2024
| @@ -71,4 +71,29 @@ class OpenRosaResponseParserImplTest { | |||
| val formList = OpenRosaResponseParserImpl().parseManifest(Document()) | |||
| assertThat(formList, equalTo(null)) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `parseManifest() when media file has type entityList returns isEntityList as true`() { | |||
There was a problem hiding this comment.
We should have a test to check if it returns false otherwise.
| @@ -941,8 +941,7 @@ | |||
| <!--Text for button that deletes all entities for the project--> | |||
| <string name="clear_entities">Poista kaikki</string> | |||
| <!--Text for button that adds a new entity list--> | |||
There was a problem hiding this comment.
You should also get rid of the explanation text above.
There was a problem hiding this comment.
I've removed it for the string in values, but won't touch it for the translated files as that should happen automatically for when new translations are added.
grzesiek2010
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6161
Closes #6229
Why is this the best possible solution? Were any other approaches considered?
Not a lot to discuss here! I just updated how we parse the form manifest.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
This does remove the ability to manually add entity lists manually to make things less confusing, but it will mean that this (and any future entity features/changes) will require testing against a version of Central that supports the
typeattribute. This change hasn't been released yet, but should be available at https://staging.getodk.cloud.Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest