Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure delete is mentioned in offline maps blurb #6222

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Make sure delete is mentioned in offline maps blurb #6222

merged 2 commits into from
Jun 21, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 21, 2024 •
edited
Loading

Updates offline layers description to highlight the ability to delete layers.

@seadowg seadowg requested a review from alyblenkin June 21, 2024 14:44
@seadowg seadowg marked this pull request as ready for review June 21, 2024 14:44
@seadowg seadowg requested a review from lognaturel June 21, 2024 17:00
alyblenkin
alyblenkin approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@alyblenkin alyblenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this issue, but I think we might want to have the layers collapsed once they are added, rather than them being expanded because it's easier to accidentally tap delete layer. Not pressing but it was something that came to mind just now.

@seadowg seadowg merged commit d1e05d3 into getodk:master Jun 21, 2024
6 checks passed
@seadowg seadowg deleted the offline-maps-delete branch June 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel approved these changes

@alyblenkin alyblenkin alyblenkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seadowg @lognaturel @alyblenkin