Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use masked appearance in text number widget #6216

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 20, 2024

Closes #6214

Why is this the best possible solution? Were any other approaches considered?

Not a lot to discuss as this just updates how we determine whether to use masked or not.

I've also removed tests around not using the masked appearance in the tests for subclasses of StringWidget and ExStringWidget as this is handled in the respective parent class tests. This was a follow-up to #6187.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Main changes are just around how masked applied.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg force-pushed the text-number-masked branch from 10c1f10 to 686ab8f Compare June 20, 2024 13:43
@seadowg seadowg marked this pull request as ready for review June 20, 2024 13:43
@seadowg seadowg requested review from grzesiek2010 and lognaturel and removed request for grzesiek2010 June 20, 2024 13:43
@seadowg seadowg merged commit 7d30e18 into getodk:master Jun 21, 2024
6 checks passed
@seadowg seadowg deleted the text-number-masked branch June 21, 2024 08:38
@dbemke
Copy link

dbemke commented Jun 21, 2024

Tested with Success!

Verified on devices with Android 10,14

Verified Cases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Answer entered in masked text numbers question can be seen on android keyboard in landscape view
3 participants