Fix autosend when using unsupported auto-send
values
#6213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6203
This makes the
auto-send
attribute behaviour (mostly) consistent with older versions. It works as described in the spec, with two additions:auto-send
attribute and forms will be auto sent based on the setting in Collect. It's likely that people have been using "default" thinking that this means something, but it doesn't.Why is this the best possible solution? Were any other approaches considered?
The biggest change here was to introduce a three element enum to try and make this less confusing. The
auto-send
attribute isn't really a "true" or "false" system - it's a "true" or "false" or "undefined" and to add to that "true" and "false" aren't really opposites. I think going with "forced", "opt-out" and "neutral" is more descriptive.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Nothing has changed except for auto send, but it's always a bit of a minefield due to the fact it has both a setting and a form attribute. I think waiting for a
behaviour verified
tag before merging would be good here.Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still passDateFormatsTest