Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setting marker icon in OSM #6090

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Apr 12, 2024

Closes #6065

Why is this the best possible solution? Were any other approaches considered?

It looks like the map in OSM needs to be invalidated programmatically. This is what we do in a few other places as well.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

This is a small fix that forces the map to be invalidated after setting the marker icon so you can focus on testing markers (how their icons are set).

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 marked this pull request as ready for review April 12, 2024 15:22
@grzesiek2010 grzesiek2010 requested a review from seadowg April 12, 2024 15:22
@seadowg seadowg merged commit 6fed771 into getodk:master Apr 15, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Apr 17, 2024

Tested with Success!

Verified on devices with Androids: 10, 14

Verified cases:

  • issue Minimizing marker on map is delayed #6065 doesn’t occur
  • selecting/deselecting points in a form map and select one from map forms
  • Google maps, Mapbox, OSM
  • selecting/ deselecting shapes and traces
  • landscape and portrait view
  • quick regression checks in geo widgets

@WKobus
Copy link

WKobus commented Apr 17, 2024

Tested with Success!

Verified on device with Android: 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimizing marker on map is delayed
4 participants