Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to surface container colors from elevation overlay #6025

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Mar 20, 2024

Closes #6010

This updates the way we defined colors for Material 3 components like dialogs or bottom sheets. Older versions of Material Components would use an "elevation overlay" color for this where as Material 3 uses the new "tonal" surface container colors.

@seadowg seadowg requested a review from alyblenkin March 20, 2024 17:44
@seadowg seadowg marked this pull request as ready for review March 20, 2024 17:45
Copy link
Collaborator

@alyblenkin alyblenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Screenshot 2024-03-20 at 1 51 52 PM

@seadowg seadowg requested a review from grzesiek2010 March 21, 2024 09:11
@grzesiek2010
Copy link
Member

This should close #6010 I believe? Or maybe it's not complete?

@seadowg
Copy link
Member Author

seadowg commented Mar 21, 2024

This should close #6010 I believe? Or maybe it's not complete?

Good point! Done.

@grzesiek2010 grzesiek2010 merged commit c19f2d3 into getodk:master Mar 21, 2024
6 checks passed
@seadowg seadowg deleted the surface-container branch March 22, 2024 10:14
@dbemke
Copy link

dbemke commented Mar 26, 2024

Tested with success!
Verified on devices with Androids: 8.1, 10, 14
Verified cases:

@WKobus
Copy link

WKobus commented Mar 26, 2024

Tested with Success!
Verified on device with Android: 11

@srujner
Copy link

srujner commented Mar 26, 2024

Tested with Success!
Verified on device with Android: 12,13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong color of background in some dialogs
6 participants