-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the typography used in the form #5962
Conversation
eec2e43
to
e3150b2
Compare
Thanks so much for investigating @grzesiek2010. The spacing feels better! It's a minor tweak, but it helps visually group the questions better. My pre-caffeine thoughts on the bold:
Curious to know what you think @lognaturel! |
It's not so much about which looks better, it's about minimizing risk of disruption so we don't get derailed again by a bunch of user pushback!
I'm in favor of this. Keeping the bold in this release and applying it consistently across the form entry and summary screens buys us time to better understand how meaningful/important the bold is today and prepare users for a change. It also lets us consider other changes we might want to make to separate questions more within a field list. |
Sounds like a plan to me! I'll approve the change |
Is it ok that the title in the app bar will be bold too? It was bold in v2023.3.1 as well because the same text appearance is used there. |
It makes sense to keep that consistent to me. @alyblenkin? |
Tested with Success! Verified on device with Android 13 Verified cases:
|
Tested with Success! Verified on device with Android 10 |
Closes #5953
Why is this the best possible solution? Were any other approaches considered?
We have discussed on slack that the space between the lines in question labels is too big now. I've investigated it and it turns out it's 28sp and in v2023.3.1 it was 24sp for the labels displayed in a form and 26sp for labels displayed in the hierarchy view. I think 24sp looks ok so that's the value I applied for both views.
When it comes to the fontWeight @lognaturel and @alyblenkin wanted to see if something bolder (like it was before in the case of the form view) would look better so please take a look and let me know what you like more:
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Just make sure that question labels in the form view and the hierarchy view are bold. Typography in other parts of the app should not change. The only exception is the app bar where the text will be bold too.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest
(or./gradlew testLab
) and confirmed all checks still pass