Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the typography used in the form #5962

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 12, 2024

Closes #5953

Why is this the best possible solution? Were any other approaches considered?

We have discussed on slack that the space between the lines in question labels is too big now. I've investigated it and it turns out it's 28sp and in v2023.3.1 it was 24sp for the labels displayed in a form and 26sp for labels displayed in the hierarchy view. I think 24sp looks ok so that's the value I applied for both views.

When it comes to the fontWeight @lognaturel and @alyblenkin wanted to see if something bolder (like it was before in the case of the form view) would look better so please take a look and let me know what you like more:

Before (master) After
Screenshot_1707738882 Screenshot_1707738550
Screenshot_1707738880 Screenshot_1707738547

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Just make sure that question labels in the form view and the hierarchy view are bold. Typography in other parts of the app should not change. The only exception is the app bar where the text will be bold too.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@alyblenkin
Copy link
Collaborator

Thanks so much for investigating @grzesiek2010. The spacing feels better! It's a minor tweak, but it helps visually group the questions better.

My pre-caffeine thoughts on the bold:

  • The bold works great for short sentences but is challenging to read when the text spans more than two lines.
  • The summary page feels heavy but connected to the form-filling experience because it's consistent with the font weight, making it easier for users to orient themselves in the flow.
  • We could ship it with these new changes and then come back to remove the bold and make other changes related to this flow, such as displaying media (images, audio, video, etc.). That would also allow us to communicate with users and identify any risks in being different from Enketo.

Curious to know what you think @lognaturel!

@lognaturel
Copy link
Member

@lognaturel and @alyblenkin wanted to see if something bolder (like it was before in the case of the form view) would look better

It's not so much about which looks better, it's about minimizing risk of disruption so we don't get derailed again by a bunch of user pushback!

We could ship it with these new changes and then come back to remove the bold and make other changes related to this flow, such as displaying media (images, audio, video, etc.). That would also allow us to communicate with users and identify any risks in being different from Enketo.

I'm in favor of this. Keeping the bold in this release and applying it consistently across the form entry and summary screens buys us time to better understand how meaningful/important the bold is today and prepare users for a change. It also lets us consider other changes we might want to make to separate questions more within a field list.

@alyblenkin alyblenkin marked this pull request as ready for review February 12, 2024 20:27
@alyblenkin
Copy link
Collaborator

alyblenkin commented Feb 12, 2024

I'm in favor of this. Keeping the bold in this release and applying it consistently across the form entry and summary screens buys us time to better understand how meaningful/important the bold is today and prepare users for a change. It also lets us consider other changes we might want to make to separate questions more within a field list.

Sounds like a plan to me! I'll approve the change

@grzesiek2010 grzesiek2010 requested a review from seadowg February 13, 2024 09:14
@grzesiek2010
Copy link
Member Author

Is it ok that the title in the app bar will be bold too? It was bold in v2023.3.1 as well because the same text appearance is used there.

@seadowg
Copy link
Member

seadowg commented Feb 13, 2024

Is it ok that the title in the app bar will be bold too? It was bold in v2023.3.1 as well because the same text appearance is used there.

It makes sense to keep that consistent to me. @alyblenkin?

@seadowg seadowg removed the request for review from lognaturel February 13, 2024 14:41
@grzesiek2010 grzesiek2010 merged commit 7147263 into getodk:master Feb 13, 2024
6 checks passed
@grzesiek2010 grzesiek2010 added needs testing high priority Should be looked at before other PRs/issues labels Feb 13, 2024
@srujner
Copy link

srujner commented Feb 14, 2024

Tested with Success!

Verified on device with Android 13

Verified cases:

@dbemke
Copy link

dbemke commented Feb 14, 2024

Tested with Success!

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bringing the bold font back to the hierarchy view
6 participants