Fallback to Material 2 OutlinedButton on API 22 #5814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5582
The problem was also now visible for the buttons shown in the quit form dialog so we wanted to see if there was anything quick we could do to fix it.
Why is this the best possible solution? Were any other approaches considered?
I've checked the problem on
master
and, as I hoped, the problem is fixed there (most likely because we're using a Material 3 theme and the latest Material Components version). We don't want to make that level of change for v2023.3 though - I've made it so that the buttons fallback to using the Material 2OutlinedButton
style for API < 22. This doesn't look amazing, but it's far better than not being able to read the text in the button.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should just fix the issue. It'd be good to have a quick hunt for any other unreadable buttons/controls.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.