Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Material 2 OutlinedButton on API 22 #5814

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 31, 2023

Closes #5582

The problem was also now visible for the buttons shown in the quit form dialog so we wanted to see if there was anything quick we could do to fix it.

Why is this the best possible solution? Were any other approaches considered?

I've checked the problem on master and, as I hoped, the problem is fixed there (most likely because we're using a Material 3 theme and the latest Material Components version). We don't want to make that level of change for v2023.3 though - I've made it so that the buttons fallback to using the Material 2 OutlinedButton style for API < 22. This doesn't look amazing, but it's far better than not being able to read the text in the button.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should just fix the issue. It'd be good to have a quick hunt for any other unreadable buttons/controls.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • added a comment above any new strings describing it for translators
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg changed the base branch from master to v2023.3.x October 31, 2023 13:59
@seadowg seadowg added this to the v2023.3 milestone Oct 31, 2023
@seadowg seadowg marked this pull request as ready for review October 31, 2023 14:18
@seadowg seadowg added the high priority Should be looked at before other PRs/issues label Oct 31, 2023
@seadowg seadowg removed the request for review from grzesiek2010 October 31, 2023 15:51
@grzesiek2010 grzesiek2010 merged commit b8d4cc8 into getodk:v2023.3.x Oct 31, 2023
6 checks passed
@seadowg seadowg deleted the outlined-button branch October 31, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants