Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check date formats parse correctly #5667

Merged
merged 5 commits into from
Jul 12, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jul 10, 2023

This adds a test to strings that checks all the strings used for date formats in every available locale to check that they won't cause parse errors (resulting in crashes).

I've additionally fixed any remaining broken strings.

@seadowg seadowg force-pushed the translation-format-test branch from 2164344 to 3802c76 Compare July 11, 2023 12:23
@seadowg seadowg marked this pull request as ready for review July 11, 2023 12:40
@seadowg seadowg force-pushed the translation-format-test branch from 041ed33 to 11e6ff6 Compare July 11, 2023 13:04
@seadowg
Copy link
Member Author

seadowg commented Jul 11, 2023

@lognaturel it probably makes sense to pull in the latest translations and get the tests green before merging this.

@seadowg seadowg added this to the v2023.2.x milestone Jul 11, 2023
@seadowg seadowg force-pushed the translation-format-test branch from 11e6ff6 to 3802c76 Compare July 12, 2023 08:39
@seadowg seadowg requested a review from grzesiek2010 July 12, 2023 08:50
@grzesiek2010 grzesiek2010 merged commit 2edf117 into getodk:v2023.2.x Jul 12, 2023
@seadowg seadowg deleted the translation-format-test branch July 12, 2023 12:21
seadowg pushed a commit to seadowg/collect that referenced this pull request Jul 14, 2023
Add test to check date formats parse correctly
grzesiek2010 added a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants