Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date format in translation #5666

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jul 10, 2023

Fixes this crash

What has been done to verify that this works as intended?

Verified manually

Why is this the best possible solution? Were any other approaches considered?

Not really any other option here!

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should just fix the issue - can be reproduced by trying to quit form entry while in a Draft with the language set to Indonesian.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as draft July 10, 2023 16:36
@seadowg seadowg requested a review from lognaturel July 10, 2023 16:38
@seadowg seadowg marked this pull request as ready for review July 10, 2023 16:38
@grzesiek2010 grzesiek2010 merged commit 1b68088 into getodk:v2023.2.x Jul 11, 2023
@seadowg seadowg deleted the fix-date-format branch July 11, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants