V2023.3 dependency updates #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
v2023.3dependency_updates
branch
20 times, most recently
from
261c65c to
3fc0ad7
Compare
grzesiek2010
force-pushed
the
v2023.3dependency_updates
branch
from
3fc0ad7 to
0f5ec7e
Compare
seadowg
reviewed
Jul 7, 2023
| @@ -5,6 +5,9 @@ | |||
| -dontwarn org.xmlpull.v1.** | |||
| -dontwarn org.hamcrest.** | |||
| -dontwarn com.rarepebble.** | |||
| -dontwarn com.networknt.** | |||
| -dontwarn android.content.res.** | |||
| -dontwarn org.kxml2.io.** | |||
There was a problem hiding this comment.
I haven't had to touch ProGuard for a while. Remind me what dontwarn is doing here?
There was a problem hiding this comment.
It ignores some weird errors I got like:
com.android.tools.r8.utils.b: Library class android.content.res.XmlResourceParser implements program class org.xmlpull.v1
It's enough for building and installing the app but we might run into some bugs on runtime too. We will see.
| @@ -26,8 +26,8 @@ android { | |||
| } | |||
| } | |||
| compileOptions { | |||
| sourceCompatibility JavaVersion.VERSION_1_8 | |||
| targetCompatibility JavaVersion.VERSION_1_8 | |||
| sourceCompatibility JavaVersion.VERSION_17 | |||
There was a problem hiding this comment.
We're ok to use Java 17 byte code on API 21? Does the new AGP take care of that?
There was a problem hiding this comment.
Everything seems to be fine. I've installed the app on Android 5 and didn't get any errors.
seadowg
approved these changes
Jul 10, 2023
grzesiek2010
force-pushed
the
v2023.3dependency_updates
branch
from
0f5ec7e to
4923901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
I've reviewed the changes and run automated tests.
Why is this the best possible solution? Were any other approaches considered?
Switching to Android Gradle Plugin 8 required some changes so this is the biggest pr with dependency updates I have ever created. The biggest change is probably Migrating to Non-Transitive R Classes We could have disabled it for now but they claim it's better not too and probably at some point in the future we would be forced to do that either way see https://developer.android.com/build/optimize-your-build#use-non-transitive-r-classes
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't require testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.