Don't start background recording when viewing forms #5653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5643
What has been done to verify that this works as intended?
New tests.
Why is this the best possible solution? Were any other approaches considered?
I actually think the better solution would be to rework
FormFillingActivity
so that the form entry, hierarchy and view only hierarchy views are all separate fragments that get navigated to after form load (depending on form state etc). This is work we've already planned (#5420), and it'd be a major effort that doesn't feel worth it to fix this one bug in isolation.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
As well as verifying the issue is fixed, checking editing and filling forms with background recordings in general would be good.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.