Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start background recording when viewing forms #5653

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 28, 2023

Closes #5643

What has been done to verify that this works as intended?

New tests.

Why is this the best possible solution? Were any other approaches considered?

I actually think the better solution would be to rework FormFillingActivity so that the form entry, hierarchy and view only hierarchy views are all separate fragments that get navigated to after form load (depending on form state etc). This is work we've already planned (#5420), and it'd be a major effort that doesn't feel worth it to fix this one bug in isolation.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

As well as verifying the issue is fixed, checking editing and filling forms with background recordings in general would be good.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review June 28, 2023 11:03
@seadowg seadowg requested a review from grzesiek2010 June 28, 2023 11:04
@seadowg seadowg added the high priority Should be looked at before other PRs/issues label Jun 28, 2023
@srujner
Copy link

srujner commented Jul 3, 2023

Tested with Success!

Verified on device with Android 12 and 13

Verified cases:

  • Issue Background Recording becomes active after viewing send form #5643 is no longer reproducing
  • background recording form
  • background recording with audit form
  • external recording is not selected
  • use an external recording app
  • use forms with audio widget
  • change recording settings in the middle of filling the form
  • light and dark mode
  • Rotate the screen, minimize the app
  • Regression check on background recording in general

@dbemke
Copy link

dbemke commented Jul 3, 2023

Tested with Success!

Verified on device with Android 10

@grzesiek2010 grzesiek2010 merged commit c896146 into getodk:master Jul 3, 2023
@seadowg seadowg deleted the background-audio-view branch July 4, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background Recording becomes active after viewing send form
4 participants